[codex] Fix personal source secret override picker#849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the source credential secret picker for personal overrides on org-owned sources.
Save inscope selector to the new-secret modal when multiple valid creation scopes are available.Root Cause
The shared React picker filtered secrets by exact target scope. A personal override binding is allowed to reference an outer org secret, but the UI hid those org-scoped secrets, making the dropdown appear empty for users with only org-level credentials.
Validation
bun run --cwd packages/react test src/plugins/secret-header-auth.test.tsbun run --cwd packages/react typecheckbun run --cwd apps/cloud test:node src/services/sources-api.node.test.ts -t "personal source override picker can see org-owned secrets over HTTP"bun run --cwd apps/cloud typecheck